Skip to content

Add Custom Metric Examples - #204

Merged
waprin merged 1 commit into
masterfrom
metrics
Feb 24, 2016
Merged

Add Custom Metric Examples#204
waprin merged 1 commit into
masterfrom
metrics

Conversation

@waprin

@waprin waprin commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2016
@waprin
waprin force-pushed the metrics branch 2 times, most recently from c03956c to d036811 Compare February 24, 2016 02:17
Comment thread monitoring/api/labeled_custom_metric.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't necessary.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@theacodes

Copy link
Copy Markdown
Contributor

Finished a pass, please let me know when you're ready for another review.

@waprin
waprin force-pushed the metrics branch 2 times, most recently from 85a83f7 to ec35e30 Compare February 24, 2016 19:50
@waprin

waprin commented Feb 24, 2016

Copy link
Copy Markdown
Contributor Author

@jonparrott ready for another pass

Comment thread monitoring/api/auth.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do gcloud-provided credentials not work for monitoring?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :(

@theacodes

Copy link
Copy Markdown
Contributor

LGTM once the last hanging apiclient is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants